The role gathers the facts it uses. For example, if the user uses
ANSIBLE_GATHERING=explicit, the role uses the setup module with the
facts and subsets it requires.

This change allows us to test this. Before every role invocation, the test
will use meta: clear_facts so that the role starts with no facts.

Create a task file tests/tasks/run_role_with_clear_facts.yml to do the tasks
to clear the facts and run the role. Note that this means we don't need to
use gather_facts for the tests.

Some vars defined using ansible_facts have been changed to be defined with
set_fact instead. This is because of the fact that vars are lazily
evaluated - the var might be referenced when the facts have been cleared, and
will issue an error like ansible_facts["distribution"] is undefined. This is
typically done for blocks that have a when condition that uses ansible_facts
and the block has a role invocation using run_role_with_clear_facts.yml
These have been rewritten to define the when condition using set_fact. This
is because the when condition is evaluated every time a task is invoked in the
block, and if the facts are cleared, this will raise an undefined variable error.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Ensure the logging role is always invoked from tests with facts cleared first, so the role must gather any facts it relies on.

Enhancements:

• Introduce a reusable run_role_with_clear_facts task wrapper that clears facts and then runs the linux-system-roles.logging role with optional public export and failure-handling semantics.
• Refactor test playbooks to use a derived is_el7 fact instead of inlined distribution checks in task parameters.

Tests:

• Update all logging role test playbooks to call the role via the new run_role_with_clear_facts task file instead of include_role directly, removing explicit gather_facts usage where no longer needed.